arch/risc-v/cmake: fix linker option case in Toolchain.cmake.#18768
Merged
simbit18 merged 1 commit intoapache:masterfrom Apr 20, 2026
Merged
Conversation
Fix lowercase -wl to correct -Wl for GCC linker pass-through option in LTO full configuration. The lowercase form is not recognized by the linker, causing --print-memory-usage to be silently ignored. Signed-off-by: v-yanxingyu <v-yanxingyu@xiaomi.com>
simbit18
approved these changes
Apr 20, 2026
xiaoxiang781216
approved these changes
Apr 20, 2026
fdcavalcanti
approved these changes
Apr 20, 2026
Contributor
fdcavalcanti
left a comment
There was a problem hiding this comment.
Thank you @yanxingyu17!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix lowercase
-wlto correct-Wlinarch/risc-v/src/cmake/Toolchain.cmake.GCC requires uppercase
-Wlas the linker option pass-through prefix.The lowercase
-wl,--print-memory-usageis silently ignored, causingno memory usage report printed during LTO full linking.
Impact
Impact on user: No
Impact on build: Yes, memory usage report now correctly printed for RISC-V LTO full builds.
Impact on hardware: No
Impact on documentation: No
Impact on security: No
Impact on compatibility: No
Testing
Build Host: Ubuntu 22.04, x86_64, GCC 13.2
Target: risc-v, qemu-rv:nsh
Testing logs before change:
Testing logs after change:
PR verification Self-Check