arch/x86: Add support to 256 color for qemu i486 VGA driver#18829
Open
acassis wants to merge 2 commits intoapache:masterfrom
Open
arch/x86: Add support to 256 color for qemu i486 VGA driver#18829acassis wants to merge 2 commits intoapache:masterfrom
acassis wants to merge 2 commits intoapache:masterfrom
Conversation
The planar copy was used even when linar mode was used (chain4 = 1) Probably this modification could impact VGA text mode, but for now it is not important, since the goal is get graphic mode working. Signed-off-by: Alan C. Assis <acassis@gmail.com>
acassis
requested review from
gustavonihei,
jerpelea and
xiaoxiang781216
as code owners
github-actions
Bot
added
Arch: x86
linguini1
approved these changes
May 1, 2026
linguini1
previously approved these changes
May 1, 2026
simbit18
previously approved these changes
May 1, 2026
This patch adds support to get the VGA driver working with 256 colors. Signed-off-by: Alan C. Assis <acassis@gmail.com>
xiaoxiang781216
approved these changes
May 2, 2026
xiaoxiang781216
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This patch will fix the issue with the colors on VGA driver
Impact
User will be able to use correct color on i486
Testing