fs/Kconfig: Add CONFIG_FS_PERMISSION option#18872
Merged
acassis merged 1 commit intoMay 14, 2026
Merged
Conversation
github-actions
Bot
added
Area: File System
Abhishekmishra2808
force-pushed
the
fs/add-fs-permission-kconfig
branch
from
020373b to
e78218c
Compare
linguini1
reviewed
May 13, 2026
Contributor
linguini1
left a comment
linguini1
left a comment
There was a problem hiding this comment.
Please finish filling out the PR template.
Also, not really much point adding Kconfig options before any features exist. I would suggest adding these along with some initial logic first, otherwise people may think there is functionality which does not exist yet.
Abhishekmishra2808
force-pushed
the
fs/add-fs-permission-kconfig
branch
2 times, most recently
from
4275d50 to
b9f2048
Compare
Abhishekmishra2808
changed the title
Contributor
Author
|
Thanks, @linguini1. I fixed the PR template and will add the initial logic shortly. |
PetervdPerk-NXP
suggested changes
May 13, 2026
Contributor
PetervdPerk-NXP
left a comment
PetervdPerk-NXP
left a comment
There was a problem hiding this comment.
Shouldn't it be "File permissions"?
acassis
reviewed
May 13, 2026
Contributor
I suggested to change to "UNIX File-system Permission", in fact it is filesystem because it also applies to directories: |
Add a CONFIG_FS_PERMISSION Kconfig option for future filesystem permission support infrastructure. The option depends on CONFIG_SCHED_USER_IDENTITY and CONFIG_PSEUDOFS_ATTRIBUTES to ensure task credential tracking and pseudo-filesystem inode ownership/mode metadata are available before enabling the feature. The symbol defaults to n to preserve existing behavior for current configurations. No runtime permission enforcement is introduced by this commit. Signed-off-by: Abhishek Mishra <mishra.abhishek2808@gmail.com>
Abhishekmishra2808
force-pushed
the
fs/add-fs-permission-kconfig
branch
from
b9f2048 to
463c26f
Compare
Contributor
Author
|
Thanks for the review, @acassis and @PetervdPerk-NXP. I have fixed all the wording you suggested in the latest commit. |
xiaoxiang781216
approved these changes
May 14, 2026
acassis
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change introduces a new CONFIG_FS_PERMISSION Kconfig option intended to act as the configuration entry point for future VFS permission support in NuttX. The option depends on
CONFIG_SCHED_USER_IDENTITYandCONFIG_PSEUDOFS_ATTRIBUTES, ensuring that task credential tracking and pseudo-filesystem inode ownership/mode metadata are available before the feature can be enabled. This commit only adds the configuration wiring and related help text; no runtime permission enforcement or access-control logic is introduced yet.Part of GSoC #18458
Note: Please adhere to Contributing Guidelines.
Impact
This change does not modify existing filesystem behavior, permission checks, or runtime access control semantics. Existing configurations remain unaffected because the new option defaults to n. The impact is limited to Kconfig integration and dependency management, allowing future filesystem permission work to build on a consistent configuration foundation without silently enabling prerequisite features.
Testing
Build Succesful
ostest
ls -l (permission bits)
make menuconfig
