Skip to content

fs/vfs: validate chmod and chown callers in inode_chstat() #18914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abhishekmishra2808 wants to merge 1 commit into
base: master
Choose a base branch
from
+28 −0
Open

fs/vfs: validate chmod and chown callers in inode_chstat() #18914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions fs/vfs/fs_chstat.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
#include <errno.h>

#include <nuttx/fs/fs.h>
#include <nuttx/sched.h>

#include "inode/inode.h"

Expand Down Expand Up @@ -410,6 +411,11 @@ int lutimens(FAR const char *path, const struct timespec times[2])
int inode_chstat(FAR struct inode *inode,
FAR const struct stat *buf, int flags, int resolve)
{
#ifdef CONFIG_SCHED_USER_IDENTITY
FAR struct tcb_s *rtcb;
uid_t euid;
#endif

DEBUGASSERT(inode != NULL && buf != NULL);

#ifdef CONFIG_PSEUDOFS_SOFTLINKS
Expand Down Expand Up @@ -443,6 +449,28 @@ int inode_chstat(FAR struct inode *inode,
}
#endif

#ifdef CONFIG_SCHED_USER_IDENTITY
rtcb = nxsched_self();
if ((rtcb->flags & TCB_FLAG_TTYPE_MASK) != TCB_FLAG_TTYPE_KERNEL &&
rtcb->group != NULL)
{
euid = rtcb->group->tg_euid;

if ((flags & (CH_STAT_UID | CH_STAT_GID)) != 0 && euid != 0)
{
return -EPERM;
}

#ifdef CONFIG_PSEUDOFS_ATTRIBUTES
if ((flags & CH_STAT_MODE) != 0 &&
euid != 0 && euid != inode->i_owner)
{
return -EPERM;
}
#endif
}
#endif

#ifdef CONFIG_PSEUDOFS_ATTRIBUTES
if (flags & CH_STAT_MODE)
{
Expand Down
Loading