drivers/usbhost_hidmouse: fix button detection in touchscreen example#18933
Merged
Conversation
Fix an issue where button presses were missed in the touchscreen example due to incorrect packet processing. Previously, the driver waited to accumulate a batch of packets but only processed the first one, effectively discarding the rest. The driver now reads and processes packets one at a time to ensure no input events are lost. Also fixed typo: usbhost_xythreshold does not exist. Signed-off-by: Lwazi Dube <lwazeh@gmail.com>
github-actions
Bot
added
Size: XS
xiaoxiang781216
approved these changes
May 21, 2026
linguini1
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix an issue where button presses were missed in the touchscreen example due to incorrect packet processing.
Previously, the driver waited to accumulate a batch of packets but only processed the first one, effectively discarding the rest. The driver now reads and processes packets one at a time to ensure no input events are lost.
Impact
Testing
Before this change nothing happened when buttons were pressed.
To test, I ran tc and:
Pressed and released left button
Pressed and released middle button
Pressed and released right button
nsh> tc
tc [8:100]
nsh> tc_main: nsamples: 0
tc_main: Opening /dev/mouse0
nsh> Sample :
buttons : 01
x : 3
y : 134
Sample :
buttons : 00
x : 3
y : 134
Sample :
buttons : 04
x : 3
y : 134
Sample :
buttons : 00
x : 3
y : 134
Sample :
buttons : 02
x : 2
y : 139
Sample :
buttons : 00
x : 1
y : 140