arch/risc-v: Fix Espressif timer registering ID#18942
Merged
Merged
Conversation
Fix Espressif timer registering ID. Espressif's general purpose timers are grouped in different Timer Groups, which may contain more than one general purpose timer. The current implementation is related to the timer groups (timer0 refers to Timer Group 0, for instance), but previous registering method was referring to the timer inside each group, which caused it to fail when more than one timer group was being selected because only the first timer on each group is being actually registered. Signed-off-by: Tiago Medicci Serrano <tiago.medicci@espressif.com>
xiaoxiang781216
approved these changes
May 22, 2026
linguini1
approved these changes
May 22, 2026
fdcavalcanti
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Impact
Impact on user: Yes. Enable registering two general purpose timers at a time.
Impact on build: No.
Impact on hardware: RISC-V-based Espressif SoCs.
Impact on documentation: No.
Impact on security: No.
Impact on compatibility: No.
Testing
Before applying this patch, only one general purpose was being properly registered at
/dev/timer0(no/dev/timer1)Building
Check it by building the same firmware before and after applying this patch. For
esp32p4-function-ev-board:timers:Running
Check timers registered at
/dev/.Results
Before this patch
Only
/dev/timer0is registered:After this patch
Both
/dev/timer0and/dev/timer1are registered: