arch/sim: Translate Apple clock IDs for macOS sim#18978
Draft
toku-mac wants to merge 1 commit into
Draft
Conversation
On the macOS simulator, that Darwin clock ID can reach NuttX clock_gettime(), where it is outside the NuttX clockid_t namespace and causes EINVAL. Add an optional architecture hook to translate clock IDs at clock_gettime() boundary. Use it for macOS sim to translate non-conflicting Apple monotonic clock IDs to NuttX CLOCK_MONOTONIC. Signed-off-by: Shoji Tokunaga <toku@mac.com>
2 tasks
| int ret; | ||
|
|
||
| #ifdef CONFIG_ARCH_HAVE_CLOCKID_TRANSLATE | ||
| clock_id = up_translate_clockid(clock_id); |
Contributor
There was a problem hiding this comment.
but, why rust tokio pass the macOS(not NuttX) clock id?
Contributor
Author
There was a problem hiding this comment.
I see. I'll look into the implementation flow of tokio::time, std::time, and clock_gettime().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes
clock_gettime()compatibility for Rust on the macOS simulator.On macOS sim, that Darwin clock ID can reach NuttX
clock_gettime(), where it is outside the NuttXclockid_tnamespace and fails withEINVAL. This causes Tokio-based Rust code to panic.The fix keeps the common clock implementation using NuttX clock IDs, and adds a small optional architecture hook for translating clock IDs at the public
clock_gettime()boundary.Impact
Running
hello_rust_cargowith nsh on macOS should no longer cause a panic.Testing
I confirm that changes are verified on local setup and works as intended:
Configuration and Build:
Testing logs before change:
Testing logs after change:
PR verification Self-Check