Suppress some "'noreturn' function does return" warnings#373
Merged
xiaoxiang781216 merged 2 commits intoapache:masterfrom Feb 25, 2020
Merged
Suppress some "'noreturn' function does return" warnings#373xiaoxiang781216 merged 2 commits intoapache:masterfrom
xiaoxiang781216 merged 2 commits intoapache:masterfrom
Conversation
|
|
||
| sys_call2(SYS_pthread_start, (uintptr_t)entrypt, (uintptr_t)arg); | ||
|
|
||
| PANIC(); |
Contributor
There was a problem hiding this comment.
But don't see who declare up_pthread_start/up_task_start as noreturn_function
Contributor
Author
There was a problem hiding this comment.
include/nuttx/arch.h has their prototypes with noreturn_function.
Contributor
There was a problem hiding this comment.
If so, we need to change all location to ensure the warning get clear for all arch or remove noreturn_function from the function declaration.
Ouss4
reviewed
Feb 25, 2020
| fprintf(stream, "/* Auto-generated %s proxy file -- do not edit */\n\n", g_parm[NAME_INDEX]); | ||
| fprintf(stream, "#include <nuttx/config.h>\n"); | ||
|
|
||
| /* Suppress "'noreturn' function does return" warnings. */ |
Member
There was a problem hiding this comment.
Suggested change
| /* Suppress "'noreturn' function does return" warnings. */ | |
| /* Suppress "'noreturn' function does return" warnings. */ | |
up_pthread_start and up_task_start.
xiaoxiang781216
approved these changes
Feb 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.