Prevents NuttX crashing if MM_REGIONS is too small.#460
Merged
Conversation
Added a DEBUGASSERT and a runtime check so that mm_region will not overwrite critical heap data if user incorrectly defines MM_REGIONS.
patacongo
reviewed
Mar 6, 2020
| int IDX = heap->mm_nregions; | ||
|
|
||
| /* Writing past CONFIG_MM_REGIONS would have catastrophic consequences */ | ||
| DEBUGASSERT(IDX < CONFIG_MM_REGIONS); |
Contributor
There was a problem hiding this comment.
Coding standard requires a blank line after each comment. tools/nxstyle should have caught this.
I will go ahead with the merge and correct that.
cwespressif
pushed a commit
to cwespressif/incubator-nuttx
that referenced
this pull request
Apr 3, 2024
…_end xtensa/esp32s3: Adjust MMU_END values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a DEBUGASSERT and a runtime check so that mm_region will not
overwrite critical heap data if user incorrectly defines MM_REGIONS.