Hotfix of local_ioctl for fcntl with O_NONBLOCK to work#8728
Hotfix of local_ioctl for fcntl with O_NONBLOCK to work#8728jturnsek wants to merge 1 commit intoapache:masterfrom
Conversation
| { | ||
| FAR struct local_conn_s *conn; | ||
| int ret = OK; | ||
| int ret = -ENOTTY; |
There was a problem hiding this comment.
@xiaoxiang781216 @anchao could you please take a look? I recall some changes around FIONBIO made some time ago related to default behavior.
There was a problem hiding this comment.
it's already be done at line 878.
There was a problem hiding this comment.
it's already be done at line 878.
I do not think it is the same. If you see the first case FIONBIO, I think there is a way to go through this case without setting ret variable, thus ret was set to OK at init and this is not the proper return value in that case. Am I wrong here?
In nuttx-apps repo, I have submitted a PR for nng with Pub/Sub example and you can test it.
There was a problem hiding this comment.
Oh, in most case, lc_infile/lc_outfile shouldn't NULL. In your case, is both NULL?
There was a problem hiding this comment.
I do not remember exactly, because it was quite some time I did the debugging. I will try again the nng example this evening with the latest code and see what happens.
There was a problem hiding this comment.
Yes, is a listen socket. NNG code is calling (void) fcntl(fd, F_SETFL, O_NONBLOCK) to set the socket in non block mode. You can see from callstack above the call to fcntl. When local_ioctl returns ENOTTY, netdev_file_ioctl is called next, which is then responsible to set s_flags for the socket. In case of OK, this doesn't happen.
There was a problem hiding this comment.
Ok, unterstand. #8751 should fix your problem and contain more context information.
There was a problem hiding this comment.
Will test with NNG.
Yesterday, when testing NNG PubSub example, I have found out that example doesn't work as it was a few months ago. Although I am getting to nng_recv (before that ENOTTY code blocked in dial) function in client thread, nothing seems to get through, altough server thread is pushing messages. Something must have been changed in local socket implementation?
There was a problem hiding this comment.
Do we close this PR?
There was a problem hiding this comment.
yes, if my patch fix your problem.
|
Closing this PR in favor of #8751. |
3 participants
Summary
Calling fcntl with O_NONBLOCK flag on local socket was not working without this change.
Impact
local_ioctl function
Testing
Working with nng library, I have found the problem and this hotfix has helped.