Skip to content

boards: stm32h7: nucleo-h743zi2: add watchdog#9303

Closed
ghost wants to merge 2 commits intomasterfrom
unknown repository
Closed

boards: stm32h7: nucleo-h743zi2: add watchdog#9303
ghost wants to merge 2 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented May 16, 2023

Summary

Add a config to test the stm32h7 watchdog

Impact

None

Testing

Builds and run

#ifdef CONFIG_STM32_IWDG
/* Initialize the watchdog timer */

stm32_iwdginitialize("/dev/watchdog0", STM32_LSI_FREQUENCY);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slorquet you can try the built-in watchdog monitor instead:
https://github.com/apache/nuttx/blob/master/drivers/timers/Kconfig#L395-L464

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do so? I need to control which task resets the watchdog.

Copy link
Author

@ghost ghost May 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followup: I did that and it works.

However, it ENTIRELY masks why I got stack corruption at context switch when trying to create a kthread like I wanted to contribute. This is still worrying.

Copy link
Contributor

@jerpelea jerpelea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a proper commit title and commit message
ex
"boards: stm32h7: nucleo: add watchdog

commit message describing the change "

@ghost ghost changed the title Nucleo watchdog boards: stm32h7: nucleo-h743zi2: add watchdog May 17, 2023
@ghost
Copy link
Author

ghost commented May 17, 2023

Contributing to nuttx is painful, specifically because of all these board tests that test canned config and miss new features.

@ghost ghost closed this May 17, 2023
@patacongo
Copy link
Contributor

Contributing to nuttx is painful, specifically because of all these board tests that test canned config and miss new features.

I tend to agree. Things are not as much fun as the old days. But with so many committers and personal with absolute authority, I think we as a group of 50 or contributors need the discipline of strict process to keep things from degenerating into chaos.

@ghost
Copy link
Author

ghost commented May 17, 2023

Surely there are reasonable reasons for this.

It will limit me to critical contributions I can't avoid. Because I dont have spoons to spend beautifying pull requests when a workaround has been found.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants