Skip to content

tools/ci: migrate some ci build configurations to CMake#9854

Merged
xiaoxiang781216 merged 2 commits intoapache:masterfrom
raiden00pl:master
Jul 21, 2023
Merged

tools/ci: migrate some ci build configurations to CMake#9854
xiaoxiang781216 merged 2 commits intoapache:masterfrom
raiden00pl:master

Conversation

@raiden00pl
Copy link
Member

Summary

tools/ci: migrate some ci build configurations to CMake

Impact

Testing

CI

@xiaoxiang781216
Copy link
Contributor

@raiden00pl please rebase your patch to the last mainline, macOS ci has been fixed.

@raiden00pl raiden00pl force-pushed the master branch 3 times, most recently from c59e6ce to ab4e64a Compare July 19, 2023 08:33
@raiden00pl
Copy link
Member Author

@xiaoxiang781216
Copy link
Contributor

@xiaoxiang781216 @anchao any idea why this job can't pass ?https://github.com/apache/nuttx/actions/runs/5596871841/jobs/10234585507?pr=9854

look like the .config is changed:

Files "/github/workspace/sources/nuttx/build/.config" to "/github/workspace/sources/nuttx/build/.config.prev" are different.

@raiden00pl
Copy link
Member Author

It's most likely from:

Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
508
Enabling CONFIG_ARM_TOOLCHAIN_CLANG

Probably cmake CI handles this wrong

@anchao
Copy link
Contributor

anchao commented Jul 20, 2023

@xiaoxiang781216 @anchao any idea why this job can't pass ?https://github.com/apache/nuttx/actions/runs/5596871841/jobs/10234585507?pr=9854

Hi @raiden00pl ,
It seems that the cmake needs to restore the previous configuration before refreshing, please try this PR
#9858

@raiden00pl raiden00pl force-pushed the master branch 2 times, most recently from ac34c44 to a60343c Compare July 20, 2023 09:23
@raiden00pl
Copy link
Member Author

@anchao thanks, this problem fixed

@raiden00pl
Copy link
Member Author

I had to disable all configurations that use external projects. For some reason FetchContent_Declare() doesn't work correctly for the version of CMake 3.16 used by CI. It works without any problem for version 3.26.4 that I have.

@xiaoxiang781216
Copy link
Contributor

I had to disable all configurations that use external projects. For some reason FetchContent_Declare() doesn't work correctly for the version of CMake 3.16 used by CI. It works without any problem for version 3.26.4 that I have.

should we upgrade to 3.26.4?

@raiden00pl
Copy link
Member Author

@xiaoxiang781216 cmake 3.16 is really old, so if there are no contraindications, it is better to use something newer.
BTW this PR passes CI now, except cmake-format not found error in Check job.

@anchao
Copy link
Contributor

anchao commented Jul 21, 2023

@xiaoxiang781216 cmake 3.16 is really old, so if there are no contraindications, it is better to use something newer. BTW this PR passes CI now, except cmake-format not found error in Check job.

Hi @raiden00pl I have a quick fix to resolve 'cmake-format' issue, let us waiting for ci finish.
#9864

@xiaoxiang781216
Copy link
Contributor

@xiaoxiang781216 cmake 3.16 is really old, so if there are no contraindications, it is better to use something newer. BTW this PR passes CI now, except cmake-format not found error in Check job.

Ok, let's merge this patch first.

@xiaoxiang781216 xiaoxiang781216 merged commit 26dda05 into apache:master Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants