Skip to content

Fixed: Canceling an item from the order view and refreshing the page caused promotional items to endlessly duplicate in the ITEM_CREATED status.#1142

Merged
arunpati merged 2 commits intoapache:trunkfrom
arunpati:ofbiz-12104-trunk
Apr 28, 2026
Merged

Fixed: Canceling an item from the order view and refreshing the page caused promotional items to endlessly duplicate in the ITEM_CREATED status.#1142
arunpati merged 2 commits intoapache:trunkfrom
arunpati:ofbiz-12104-trunk

Conversation

@arunpati
Copy link
Copy Markdown
Contributor

Fixed: Canceling an item from the order view and refreshing the page caused promotional items to endlessly duplicate in the ITEM_CREATED status. (OFBIZ-12104)

Explanation:

  1. The recreateOrderAdjustments service created new promotional items but failed to link them to their ship groups (OrderItemShipGroupAssoc). Without this link, the cancellation service could not identify or remove them during subsequent runs, causing items to accumulate.
  2. New promotional items were hardcoded to the ITEM_CREATED status, even if the parent order was already ORDER_APPROVED.

Thanks to Rashi Dhagat for reporting issue.

…he page causes promotional items to endlessly duplicate in the ITEM_CREATED status.(OFBIZ-12104)
@arunpati arunpati merged commit 84ca53d into apache:trunk Apr 28, 2026
4 of 5 checks passed
asf-gitbox-commits pushed a commit that referenced this pull request Apr 29, 2026
…caused

promotional items to endlessly duplicate in the ITEM_CREATED status. (#1142)

Fixes 4 Codenarc issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant