Refactor Groovy EntityListIterator usage with auto-closeable handling…#1167
Merged
dixitdeepak merged 1 commit intoapache:trunkfrom May 7, 2026
Merged
Conversation
… (OFBIZ-13399) Updated Groovy files to use safer resource management patterns for EntityListIterator. - Replaced manual iterator close handling with try-with-resources style implementations where applicable - Used Groovy withCloseable for automatic resource cleanup - Replaced EntityListIterator usage with EntityQuery.queryPagedList() where only partial/paged results were required - Removed unnecessary manual close() calls - Reduced risk of JDBC cursor and ResultSet resource leaks - Improved readability and aligned code with modern OFBiz best practices Changes were applied to Groovy files; full regression testing has not yet been completed for all updated flows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved : Updated Groovy files to use safer resource management patterns for EntityListIterator (OFBIZ-13399)
Changes were applied to Groovy files; full regression testing has not yet been completed for all updated flows.