Improved: create invoice service (OFBIZ-12387)#345
Closed
PierreSmits wants to merge 2 commits intoapache:trunkfrom
Closed
Improved: create invoice service (OFBIZ-12387)#345PierreSmits wants to merge 2 commits intoapache:trunkfrom
PierreSmits wants to merge 2 commits intoapache:trunkfrom
Conversation
added: InvoiceServices.groovy: def createInvoice - the added service also checks and ensures that the user has the appropriate PartyRole - the added service also creates the InvoiceRole record for the user AccountingSeedData.xml - RoleType definitions for InvoiceRole modified: services_invoice.xml, createInvoice: engine attribute and location attribute removed: InvoiceServices.xml: simple-method createInvoice added
* trunk: Improved: Try to reduce the SARIF file used by CodeQL for Java classes (OFBIZ-12361)
PierreSmits
changed the title
PierreSmits
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
The changes are not only a conversion to Groovy but also introduce changes to the service business logic. |
Contributor
|
I agree with Michael, explanations are less about what you did, but more about why you did them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added:
InvoiceServices.groovy: def createInvoice
AccountingSeedData.xml
modified:
services_invoice.xml, createInvoice: engine attribute and location attribute
removed:
InvoiceServices.xml: simple-method createInvoice