Skip to content

Fixed: Payment Applications shows wrong label translation (OFBIZ-12425)#376

Merged
JacquesLeRoux merged 1 commit into
apache:trunkfrom
PierreSmits:OFBIZ-12425-Payments-Allocation-Label
Dec 2, 2021
Merged

Fixed: Payment Applications shows wrong label translation (OFBIZ-12425)#376
JacquesLeRoux merged 1 commit into
apache:trunkfrom
PierreSmits:OFBIZ-12425-Payments-Allocation-Label

Conversation

@PierreSmits
Copy link
Copy Markdown
Member

See: https://demo-trunk.ofbiz.apache.org/accounting/control/editPaymentApplications?paymentId=8004 compared to https://demo-stable.ofbiz.apache.org/accounting/control/editPaymentApplications?paymentId=8004
With changes committed under 4aa2d71 the label used changed, see below

  •                            <container><label style="h1" text="${uiLabelMap.AccountingPayment} ${uiLabelMap.AccountingApplications}"/></container>
    
  •                            <container><label style="h1" text="${uiLabelMap.AccountingPayment} ${uiLabelMap.AccountingPaymentsApplications}"/></container>
    

giving the resulting change from 'Payment Applications' for the section/screenlet (as inline with the menu-item with translation 'Applications') to 'Payment Payments'

modified: EditPaymentsApplications screen in PaymentScreens.xml
changed label combination for a more suitable label.

See: https://demo-trunk.ofbiz.apache.org/accounting/control/editPaymentApplications?paymentId=8004 compared to https://demo-stable.ofbiz.apache.org/accounting/control/editPaymentApplications?paymentId=8004
With changes committed under  apache@4aa2d71 the label used changed, see below
-                                <container><label style="h1" text="${uiLabelMap.AccountingPayment} ${uiLabelMap.AccountingApplications}"/></container>
+                                <container><label style="h1" text="${uiLabelMap.AccountingPayment} ${uiLabelMap.AccountingPaymentsApplications}"/></container>

giving the resulting change from 'Payment Applications' for the section/screenlet (as inline with the menu-item with translation 'Applications') to 'Payment Payments'

modified: EditPaymentsApplications screen in PaymentScreens.xml
changed label combination for a more suitable label.
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JacquesLeRoux JacquesLeRoux merged commit b262327 into apache:trunk Dec 2, 2021
@PierreSmits PierreSmits deleted the OFBIZ-12425-Payments-Allocation-Label branch December 2, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants