Improved: VIEW permissions - invoice notes (OFBIZ-12431)

[PierreSmits]

Though there is an entity InvoiceNote, this cannot be accessed by user with VIEW permissions when accessing an invoice.
See:
for entity data:https://demo-trunk.ofbiz.apache.org/webtools/control/entity/find/InvoiceNote
test invoice: https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo11001

Modified:
AccountingMenus.xml

• added menu-item for invoice notes to InvoiceTabBar menu, reordered menu-items alphabetically
  controller.xml
• added request-map and view-map for request invoiceNotes
  InvoiceScreens.xml
• added screen for invoice notes
  InvoiceForms.xml
• added grid to display InvoiceNote records
  AccountingUiLabels.xml
• added label for page title invoice notes.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[JacquesLeRoux]

Hi Pierre,

It works but you forgot to (at least) mention the (right) changes in AccountingMenus::editInvoiceApplications and EditInvoiceTimeEntries. It's OK but please rather open specific issues for these kind of changes. It's much work for reviewers/committers to understand what is really done, TIA

[PierreSmits]

Good morning Jacques,

Are you referring to the alphabetically reordering of certain menu-items in the InvoiceTabBar menu? If you are, I suggest you pay attention to the first 2 lines beneath 'modified in both commit and PR message.

[JacquesLeRoux]

I meant the "add" of


But it's indeed actually the reordering that mislead me (removed on one side added to other, I used the horizontal GH review).