Improved: VIEW permissions Commission Run (OFBIZ-12433) #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when using a userId with only VIEW permission, the Commission Run trigger (menuItem) presents a screen to search and find invoices applicable for the underlying service of creating commission invoices. On the result shown, the user has access to triggers (functionalities) reserved for users with CREATE/UPDATE permissions. See (test with): https://demo-trunk.ofbiz.apache.org/accounting/control/CommissionRun and from date= 12/1/1999 12:00:00 AM Modified: InvoiceScreens.xml (in AP) - screen CommissionRun - restructured the screen to show result based on permissions - added reference to template for users with VIEW permissions Added: CommissionRunSearchResult.ftl template for users with VIEW permissions
Currently, when using a userId with only VIEW permission, the Commission Run trigger (menuItem) presents a screen to search and find invoices applicable for the underlying service of creating commission invoices. On the result shown, the user has access to triggers (functionalities) reserved for users with CREATE/UPDATE permissions. See (test with): https://demo-trunk.ofbiz.apache.org/accounting/control/CommissionRun and from date= 12/1/1999 12:00:00 AM Modified: InvoiceScreens.xml (in AP) - screen CommissionRun - restructured the screen to show result based on permissions - added reference to template for users with VIEW permissions Added: CommissionRunSearchResult.ftl template for users with VIEW permissions
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
Hi Pierre, Why using Freemarker rather than Widgets? |
Member
Author
|
Good afternoon Jacques, For several reasons:
|
Contributor
|
I was only interested in point 1, but thanks |
Member
Author
|
Then you can regard point 2 as a bonus. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when using a userId with only VIEW permission, the Commission Run trigger (menuItem) presents a screen to search and find invoices applicable for the underlying service of creating commission invoices.
On the result shown, the user has access to triggers (functionalities) reserved for users with CREATE/UPDATE permissions.
See (test with): https://demo-trunk.ofbiz.apache.org/accounting/control/CommissionRun and from date= 12/1/1999 12:00:00 AM
Modified:
InvoiceScreens.xml (in AP) - screen CommissionRun
Added:
CommissionRunSearchResult.ftl template for users with VIEW permissions