Improved: VIEW permissions FinAccount roles (OFBIZ-12435) #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo with userId = auditor, accessing the Financial Account Roles screen sees editable fields and/or triggers (to requests) reserved for users with 'CREATE' or 'UPDATE' permissions. See (test with): [https://demo-trunk.ofbiz.apache.org/accounting/control/EditFinAccount?finAccountId=ABN_CHECKING] Modified: FinAccountScreens.xml - restructured EditFinAccount FinAccountForms.xml - added FinAccountRoles form, restructured ListFinAccountRoles
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
Pierre, I guess you will continue to disable for auditor (or alike) the screens accessible from this screen? As it would not make sense to disable the menus themselves, right? |
Member
Author
|
Hi Jacques, Thanks for the question. How would users then go from one sub element to another given the same object? |
Contributor
|
Forget it, I just meant that the screens accessible from the sub-menus should still be accessible, nothing new. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo with userId = auditor, accessing the Financial Account Roles screen sees editable fields and/or triggers (to requests) reserved for users with 'CREATE' or 'UPDATE' permissions.
See (test with): https://demo-trunk.ofbiz.apache.org/accounting/control/EditFinAccount?finAccountId=ABN_CHECKING
Modified:
FinAccountScreens.xml - restructured EditFinAccount
FinAccountForms.xml - added FinAccountRoles form, restructured ListFinAccountRoles