Improved: List and Grid (OFBIZ-11345)

[PierreSmits]

According to the definition in widget-form.xsd the use of a combination of a form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor various list form references in screens.

Modified:
ProductScreens.xml in product: from form ref to grid ref , additional cleanup
ProductForms.xml: from form definition with list ref to grid definition with list ref, additional clean-up

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[JacquesLeRoux]

Hi Pierre,

ListSupplierProductAgreements, ListSalesAgreements, ListProductAgreements, UpdateProductCategoryMember, UpdateProductConfig, ListProductFixedAssets, ListProductRoutings, "you name it" grids don't exist. Maybe you miss a file?

[PierreSmits]

Hi Jacques,

Thanks for the review and the feedback. I will have a look.

[PierreSmits]

ListSalesAgreements appears in both ProductScreens.xml and ProductForms.xml. Changes appear in both, see https://github.com/apache/ofbiz-framework/pull/427/files
ListSupplierProductAgreements the same
ListProductAgreements the same
UpdateProductCategoryMember the same
UpdateProductConfig the same
ListProductFixedAssets the same
ListProductRoutings the same

Maybe you need to expand the diff (via the url provided) to see the changes in ProductForms.xml

[JacquesLeRoux]

Right Pierre,

What about ListProductTag?

[PierreSmits]

ListProductTag is not a form of type="list" but rather of type="multi" and therefor not converted to a grid. Just a minor cleanup happened there.

[JacquesLeRoux]

Yes I know, paginate-target="EditProductTag" was wrong, right?

[PierreSmits]

It is a valid request. So it appear appropriate for a paginate-target.

-    <form name="ListProductTag" type="multi" target="updateProductTag" title="" list-name="productKeywordList"
         odd-row-style="alternate-row" default-table-style="basic-table" paginate-target="EditProductTag" separate-columns="true">
 +    <form name="ListProductTag" list-name="productKeywordList" type="multi" target="updateProductTag" paginate-target="EditProductTag"
         odd-row-style="alternate-row" default-table-style="basic-table" separate-columns="true">

As you can see in the change the clean-up is about remove of the title tag and bringing the paginate-target from the 2nd line to the 1st.