Improved: VIEW permissions - BillingAccount roles (OFBIZ-12487)#440
Merged
JacquesLeRoux merged 1 commit intoapache:trunkfrom Jan 20, 2022
Merged
Conversation
Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo with userId = auditor, accessing the billing account roles screen, sees editable fields and/or triggers (to requests) reserved for users with 'CREATE' or 'UPDATE' permissions. See (test with): https://localhost:8443/accounting/control/EditBillingAccountRoles?billingAccountId=9010 Modified: BillingAccountScreens.xml, re EditBillingAccountRoles: - added permission rules for CREATE/UPDATE - restructured section and widget/fail-widget elements, additional cleanup BillingAccountForms.xml - added grid BillingAccountRoles (based on ListBillingAccountRoles) - additional cleanup/label harmonisation
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo with userId = auditor, accessing the billing account roles screen, sees editable fields and/or triggers (to requests) reserved for users with 'CREATE' or 'UPDATE' permissions.
See (test with): https://localhost:8443/accounting/control/EditBillingAccountRoles?billingAccountId=9010
Modified:
BillingAccountScreens.xml, re EditBillingAccountRoles:
BillingAccountForms.xml