Improved: Move edit of Payment Group to SubTabBar (OFBIZ-12501)#456
Merged
JacquesLeRoux merged 1 commit intoapache:trunkfrom Jan 18, 2022
Merged
Conversation
In general, a <object>TabBar menu is intended to give users access to overviews related to the <object>. And a <object>SubTabBar menu is intended to give users access to actions to be performed on the <object>, like status changes, adding new related records, etc. The menu-item for editing a payment group is currently located in the PaymentGroupTabBar menu in AccountingMenus.xml. The menu item belongs in the PaymentGroupSubTabBar Improved: AccountingMenus.xml PaymentGroupTabBar: removed menu item to edit the payment group, additonal cleanup PaymentGroupSubTabBar: Added menu iteem to edit the payment group, additional cleanup
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In general, a [object]TabBar menu is intended to give
users access to overviews related to the .
And a [object]SubTabBar menu is intended to give
users access to actions to be performed on the [object],
like status changes, adding new related records, etc.
The menu-item for editing a payment group is currently
located in the PaymentGroupTabBar menu in AccountingMenus.xml.
The menu item belongs in the PaymentGroupSubTabBar
Improved: AccountingMenus.xml
PaymentGroupTabBar: removed menu item to edit the payment group, additonal cleanup
PaymentGroupSubTabBar: Added menu iteem to edit the payment group, additional cleanup