Fixed: various bugs in receive against purchase orders (OFBIZ-13327) #932
Conversation
…ipment ID field in the Receive Against PO screen, because the screen is one of the sub-tabs of the shipment screen.
…to properly display receive quantity in the Receive Against PO screen, in case of order items splitted in multiple ship groups.
…shipment id, but no shipment item sequence id
|
JacquesLeRoux
changed the title
|
I have created https://issues.apache.org/jira/browse/OFBIZ-13327 related to this PR As I said there not sure there will be subtasks or not
|
|
Thank you, @JacquesLeRoux (Hi @gilPts !) Let me know if you need any clarification on the changes. Anahita |
|
Hi Anahita, I tested the Receive Against PO screen and the result in the main order screen and I did not find any issues. I received respectively 8 on 10 (shipment 2) and 5 on 7 (shipment 1). Of course I did not use the 'Force Complete Purchase Order' as we known it's deficient. I just want to mention that https://issues.apache.org/jira/browse/OFBIZ-9592 Paul is working on an enhancement of the main order screen. There should not be any interaction at this stage, just mentioning. |
JacquesLeRoux
left a comment
JacquesLeRoux
left a comment
There was a problem hiding this comment.
That sounds OK with me to push
|
Hi Jacques, thank you for the test and the review. And thank you for pointing out Paul's work. Just so you know, I'm already working on fixing the 'Force Complete Purchase Order' button behavior and I'm almost done. Have a good day Anahita |
|
Hi @JacquesLeRoux, do you know if @gilPts is willing to review the PR? Thanks and happy holidays |
|
Hi Anahita, No I don't know. I guess he will get the message and answer himself. BTW, did you ask for his review or did he pick it himself? Have fun too 😄 ❄️. |
|
Hi Jacques, |
|
Thanks Anahita, I guess I clicked on the wrong line then. I remove. |
|
Do you need more time before pushing this PR? |
|
No, Jacques, thank you. I have already thoroughly tested the changes, and I am comfortable with them. |
…932) - Ensure shipGroupSeqId is correctly set in context and passed to the template. - Display order items quantities for the selected ship group. - Make Order ID and Ship Group ID read-only fields and remove Shipment ID field in the Receive Against PO screen, because the screen is one of the sub-tabs of the shipment screen. - Add logic to filter shipment receipts by ship group, in order to properly display receive quantity in the Receive Against PO screen, in case of order items split into multiple ship groups. - Fix bug that causes creation of shipment receipt records with shipment id, but no shipment item sequence id Explanation: various bugs were discovered when receiving an order item split into more than one ship group, by means of the Receive Against PO screen. The PR fixes those regarding the correct determination and visualization of quantities per ship group, e.g., 'order', 'received', etc. There are still outstanding bugs in the trunk, such as the 'Force Complete Purchase Order' that still doesn't support order items split into multiple ship groups, wrong invoice creation, etc.
…pache#932) - Ensure shipGroupSeqId is correctly set in context and passed to the template. - Display order items quantities for the selected ship group. - Make Order ID and Ship Group ID read-only fields and remove Shipment ID field in the Receive Against PO screen, because the screen is one of the sub-tabs of the shipment screen. - Add logic to filter shipment receipts by ship group, in order to properly display receive quantity in the Receive Against PO screen, in case of order items split into multiple ship groups. - Fix bug that causes creation of shipment receipt records with shipment id, but no shipment item sequence id Explanation: various bugs were discovered when receiving an order item split into more than one ship group, by means of the Receive Against PO screen. The PR fixes those regarding the correct determination and visualization of quantities per ship group, e.g., 'order', 'received', etc. There are still outstanding bugs in the trunk, such as the 'Force Complete Purchase Order' that still doesn't support order items split into multiple ship groups, wrong invoice creation, etc.
2 participants
Explanation: various bugs were discovered when receiving an order item split into more than one ship group, by means of the Receive Against PO screen. The PR fixes those regarding the correct determination and visualization of quantities per ship group, e.g., 'order', 'received', etc.
There are still outstanding bugs in the trunk, such as the 'Force Complete Purchase Order' that still doesn't support order items split into multiple ship groups, wrong invoice creation, etc.