Fixed: refactor CORS handling in APICorsFilter to use allowed origins and improve response headers#170
Open
golja wants to merge 1 commit intoapache:trunkfrom
Open
Fixed: refactor CORS handling in APICorsFilter to use allowed origins and improve response headers#170golja wants to merge 1 commit intoapache:trunkfrom
golja wants to merge 1 commit intoapache:trunkfrom
Conversation
… and improve response headers
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue raised by @gsperi on the dev-list on March 23, 2026 (subject: "rest-api plugin and CORS filter") regarding the incorrect handling of CORS origins in the rest-api plugin.
Dependent on PR #1034, this PR updates the APICorsFilter class to correctly compare the request's Origin header against the list of allowed origins and to populate the Access-Control-Allow-Origin response header based on the matching result.