Skip to content

bug: GHA backend uses fragile string interpolation to construct URLs #7382

@JadedBlueEyes

Description

@JadedBlueEyes

Describe the bug

"{}{CACHE_URL_BASE}/cache?keys={}&version={}",
results in incorrect URL construction when the base URL is missing a trailing /. This means access fails.

Steps to Reproduce

Set ACTIONS_CACHE_URL to a base URL without a trailing slash

Expected Behavior

A safe URL manipulation function is used that correctly constructs a relative URL

Additional Context

This has been an issue on some self-hosted forgejo actions runners.

Are you willing to submit a PR to fix this bug?

  • Yes, I would like to submit a PR.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingreleases-note/fixThe PR fixes a bug or has a title that begins with "fix"rustPull requests that update Rust codeservices/ghac

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions