Skip to content

improve blocking read use read_to_end #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Xuanwo merged 1 commit into from
Dec 13, 2022
Merged

improve blocking read use read_to_end #1072

Xuanwo merged 1 commit into from
Dec 13, 2022

Conversation

@sundy-li
Copy link
Contributor

@sundy-li sundy-li commented Dec 13, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

  1. fix a bug in bench
  2. use read_to_end instead of std::io::copy

@sundy-li sundy-li requested a review from Xuanwo December 13, 2022 02:07
Xuanwo
Xuanwo approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@Xuanwo Xuanwo merged commit 98d2aa0 into main Dec 13, 2022
@Xuanwo Xuanwo deleted the blocking-read branch December 13, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sundy-li @Xuanwo