-
Notifications
You must be signed in to change notification settings - Fork 703
feat(bindings/java): add java binding #1736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for the pull request! At OpenDAL, we prefer to split pull requests into smaller chunks for faster review and merging. It would be better if we create a tracking issue instead. In this PR, I expect to the basic setup, and future impove can be done later. |
Sure, I will put them in readme for memo and will add issues after this pr get merged. |
|
You can use the following command to format license: docker run -it --rm -v $(pwd):/github/workspace -u $(id -u):$(id -g) ghcr.io/korandoru/hawkeye-native format |
|
You may track them in #1572 |
Sounds good. Can it be integrated? Or is it possible to directly implement Java binding using Kotlin? |
Thanks.
Yes, both integration or writing in Kotlin entirely work for Java and Kotlin. A open question is how do we handling running model for Executor and Waker:
|
We can consider implementing them in the future, but for now let's prioritize blocking support. I believe it's best to address one problem at a time. |
1e0334c to
e54e6cb
Compare
Xuanwo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Let's keep moving on.
Explanation:
Operator.javaand free it when Java instance be destroyed by GC.