Skip to content

feat(oli): load config from both env and file #1737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Xuanwo merged 2 commits into from
Mar 23, 2023
Merged

feat(oli): load config from both env and file #1737

Xuanwo merged 2 commits into from
Mar 23, 2023

Conversation

@knight42
Copy link
Contributor

@knight42 knight42 commented Mar 23, 2023

Per RFC:

Besides, `oil` will read profile from env like `cargo`:

- `OIL_PROFILE_TEST_TYPE=s3`
- `OIL_PROFILE_TEST_ENDPOINT=http://127.0.0.1:1090`
- `OIL_PROFILE_TEST_BUCKET=test_bucket`
- `OIL_PROFILE_TEST_ACCESS_KEPT_ID=access_key_id`
- `OIL_PROFILE_TEST_SECRET_ACCESS_KEY=secret_access_key`

oli should be able to be configured by environment variables.

@knight42
feat(oli): load config from both env and file
90cf527 
Signed-off-by: Jian Zeng <anonymousknight96@gmail.com>
Xuanwo
Xuanwo reviewed Mar 23, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM, great work!

@knight42
style: switch to &Path
ae7ecc1 
Signed-off-by: Jian Zeng <anonymousknight96@gmail.com>
Xuanwo
Xuanwo approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@Xuanwo Xuanwo merged commit 524b787 into apache:main Mar 23, 2023
@knight42 knight42 deleted the feat/load-config-from-env-and-file branch March 23, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@knight42 @Xuanwo