feat: add writer support for aliyun oss #1842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
approved these changes
Apr 2, 2023
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Mostly LGTM! Thank you very much. This pull request can be merged once all the CI tests have passed.
Contributor
Author
Sorry for the delay. I'm trying to do some tests on oss to ensure the correctness |
Member
This test is included in our behavior tests and can be run using |
Member
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Writer support for aliyun OSS so that it can leverage the multipart upload functionality to append bytes to objects.
This PR fixes #1761