Skip to content

feat(bindings/c): fix c bindings makefile #1849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Xuanwo merged 1 commit into from
Apr 4, 2023
Merged

feat(bindings/c): fix c bindings makefile #1849

Xuanwo merged 1 commit into from
Apr 4, 2023

Conversation

@xyjixyjixyji
Copy link
Contributor

@xyjixyjixyji xyjixyjixyji commented Apr 4, 2023

Fixed the OBJDIR creation and library link flag

  • The library created by cbindgen is called libopendal_c instead of libopendal, so the original -lopendal does not work
  • At least on my machine, the OBJDIR is not created by the Makefile, so this change make sure that the directory is created.

@xyjixyjixyji
feat(bindings/c): fix c bindings makefile
18c08c6 
Fixed the OBJDIR creation and library link flag

Signed-off-by: Ji-Xinyou <jerryji0414@outlook.com>
Xuanwo
Xuanwo approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 834957c into apache:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xyjixyjixyji @Xuanwo