Skip to content

fix(core): S3 Copy should set SSE headers #1860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Xuanwo merged 4 commits into from
Apr 5, 2023
Merged

fix(core): S3 Copy should set SSE headers #1860

Xuanwo merged 4 commits into from
Apr 5, 2023

Conversation

@suyanhanx
Copy link
Member

@suyanhanx suyanhanx commented Apr 5, 2023 •
edited
Loading

fix #1858

suyanhanx added 2 commits April 5, 2023 23:15
@suyanhanx
fix(core): s3 copy sse
1de59be 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx
remove copy check permissonDenied
3101ec9 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@Xuanwo Xuanwo mentioned this pull request Apr 5, 2023
Closed
@Xuanwo Xuanwo changed the title Fix s3 copy sse fix(core): S3 Copy should set SSE headers Apr 5, 2023
@suyanhanx
add fields about copy source sse
b9a29a6 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx
Copy link
Member Author

suyanhanx commented Apr 5, 2023 •
edited
Loading

Need to set 3 new secret keys @Xuanwo

@Xuanwo
Copy link
Member

Xuanwo commented Apr 5, 2023

Need to set 3 new secret keys @Xuanwo

No, we don't need to. Use the same bucket key is enough. We only support copy in the same bucket for now.

@suyanhanx
Copy link
Member Author

suyanhanx commented Apr 5, 2023

Need to set 3 new secret keys @Xuanwo

No, we don't need to. Use the same bucket key is enough. We only support copy in the same bucket for now.

Yep. I'm updating workflow.

Xuanwo
Xuanwo reviewed Apr 5, 2023
View reviewed changes
@Xuanwo
Copy link
Member

Xuanwo commented Apr 5, 2023

Yep. I'm updating workflow.

No, you misunderstand what I mean. We don't need to add new config values.

@suyanhanx
Copy link
Member Author

suyanhanx commented Apr 5, 2023

No, you misunderstand what I mean. We don't need to add new config values.

Oh yes. I understand.

@suyanhanx
use sse headers to fill copy_source_sse config
71167bb 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Xuanwo
Xuanwo approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot!

@Xuanwo Xuanwo merged commit 51db918 into main Apr 5, 2023
@Xuanwo Xuanwo deleted the fix-s3-copy-sse branch April 5, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: s3 copy should handle SSE related headers

2 participants

@suyanhanx @Xuanwo