feat: Add feature flag for all services #1915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <github@xuanwo.io>
suyanhanx
changed the title
ClSlaid
approved these changes
Apr 12, 2023
Contributor
ClSlaid
left a comment
ClSlaid
left a comment
There was a problem hiding this comment.
Slimmer OpenDAL, fits for more suites! 👍🏻️
Signed-off-by: Xuanwo <github@xuanwo.io>
Member
|
We may also need to update readme to tell users this change. |
Member
Author
We will mention this in UPGRADE. |
Member
|
As a feature that will exist for a long time in the future, we still need to mention it in the document. Not just in the changelog. 👀 |
wcy-fdu
pushed a commit
to wcy-fdu/opendal
that referenced
this pull request
Apr 12, 2023
* feat: Add feature for all services Signed-off-by: Xuanwo <github@xuanwo.io> * fix unit test Signed-off-by: Xuanwo <github@xuanwo.io> --------- Signed-off-by: Xuanwo <github@xuanwo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.