Skip to content

Conversation

@Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Apr 12, 2023

Polish the behavior of scan to make sure the prefix itself not returned.

Signed-off-by: Xuanwo <github@xuanwo.io>
Xuanwo added 4 commits April 12, 2023 19:27
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Copy link
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PsiACE
Copy link
Member

PsiACE commented Apr 12, 2023

lgtm

Oops, unit test failed 😭

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 12, 2023

lgtm

Oops, unit test failed sob

Nevermind, fix coming.

Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on ci green. Thanks.

@Xuanwo Xuanwo merged commit 74d92a1 into main Apr 12, 2023
@Xuanwo Xuanwo deleted the add-docs-for-scan branch April 12, 2023 12:34
wcy-fdu pushed a commit to wcy-fdu/opendal that referenced this pull request Apr 12, 2023
* refactor: Polish the behavior of scan

Signed-off-by: Xuanwo <github@xuanwo.io>

* FIx test for sled

Signed-off-by: Xuanwo <github@xuanwo.io>

* Fix sled

Signed-off-by: Xuanwo <github@xuanwo.io>

* Fix CI

Signed-off-by: Xuanwo <github@xuanwo.io>

* Make clippy happy

Signed-off-by: Xuanwo <github@xuanwo.io>

* FIx kv adapter

Signed-off-by: Xuanwo <github@xuanwo.io>

---------

Signed-off-by: Xuanwo <github@xuanwo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants