Skip to content

feat(layers): add a basic minitrace layer #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Xuanwo merged 8 commits into from
Apr 13, 2023
Merged

feat(layers): add a basic minitrace layer #1931

Xuanwo merged 8 commits into from
Apr 13, 2023

Conversation

@PsiACE
Copy link
Member

@PsiACE PsiACE commented Apr 12, 2023 •
edited by Xuanwo
Loading

It simply works and needs to consider how to properly reflect the parent-child relationship of the call.

Fix #691

PsiACE added 5 commits April 13, 2023 04:00
@PsiACE
feat(layers): add minitrace layers
3cbc6fe 
Signed-off-by: Chojan Shang <psiace@outlook.com>
@PsiACE
chore(layers/minitrace): add inner and blocking prefix
57758ff 
Signed-off-by: Chojan Shang <psiace@outlook.com>
@PsiACE
refactor(layers/minitrace): add relationship for blocking op
ae00810 
Signed-off-by: Chojan Shang <psiace@outlook.com>
@PsiACE
refactor(layers/minitrace): add relationship for async op
e1061fc 
Signed-off-by: Chojan Shang <psiace@outlook.com>
@PsiACE
refactor(layers/minitrace): use enter with parent
c2eddcb 
Signed-off-by: Chojan Shang <psiace@outlook.com>
@PsiACE
Copy link
Member Author

PsiACE commented Apr 12, 2023

It seems to be working fine now.

@Xuanwo
Copy link
Member

Xuanwo commented Apr 13, 2023

Also, cc @andylokandy to give us some advice

Xuanwo
Xuanwo reviewed Apr 13, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see we have a minitrace layer!

@PsiACE
refactor(layers/minitrace): enter on poll and better name
fa4ea4c 
Signed-off-by: Chojan Shang <psiace@outlook.com>
@PsiACE
Copy link
Member Author

PsiACE commented Apr 13, 2023

now, we use enter_on_poll to trace async function

Xuanwo
Xuanwo reviewed Apr 13, 2023
View reviewed changes
@PsiACE
refactor(layers/minitrace): use into_static to get operation name
af64ad2 
Signed-off-by: Chojan Shang <psiace@outlook.com>
Xuanwo
Xuanwo approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@PsiACE
Copy link
Member Author

PsiACE commented Apr 13, 2023

Xuanwo
Xuanwo reviewed Apr 13, 2023
View reviewed changes
@PsiACE
refactor(layers/minitrace): reuse span
7436fa6 
Signed-off-by: Chojan Shang <psiace@outlook.com>
@PsiACE
Copy link
Member Author

PsiACE commented Apr 13, 2023

@Xuanwo
Copy link
Member

Xuanwo commented Apr 13, 2023

Nice!

@Xuanwo Xuanwo merged commit 9510ca6 into apache:main Apr 13, 2023
@PsiACE PsiACE deleted the minitrace-layer branch April 13, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a layer to integrate minitrace

2 participants

@PsiACE @Xuanwo