Skip to content

fix: kv adapter's writer implementation fixed to honour empty writes #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Xuanwo merged 1 commit into from
Apr 13, 2023
Merged

fix: kv adapter's writer implementation fixed to honour empty writes #1934

Xuanwo merged 1 commit into from
Apr 13, 2023

Conversation

@damooo
Copy link
Contributor

@damooo damooo commented Apr 13, 2023

fixes #1791

Xuanwo
Xuanwo approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damooo damooo marked this pull request as ready for review April 13, 2023 10:17
@Xuanwo Xuanwo merged commit 21a45c7 into apache:main Apr 13, 2023
@damooo damooo deleted the kv_writer_fix branch April 13, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

KV backend's writer will not create object with empty content.

2 participants

@damooo @Xuanwo