-
Notifications
You must be signed in to change notification settings - Fork 702
feat: add Writer::abort method #1937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi, @v0y4g3r, is this PR ready for review? Do you want to add |
Maybe I can add S3 implementation along with the |
LGTM! |
0220728 to
e139bc0
Compare
Xuanwo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM!
Xuanwo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
I'm wondering if we can add a service test for |
Yes, we can add abort in behavior test (by ignoring not support errors)! This is PR good to get merged. How about adding a new PR for that? |
This PR:
oio::Write::abortAPI to allow cancellation of an on-going append writerappend, adds aWrite::abortimplementation that simply returnOk(())oio::Write::abortfor all layersoio::Write::abortimplementation forS3Writeras an exampleThis PR does not add an equivalent API in
oio::BlockingWrite, since we can always add aDropimplementation for blocking writers and delete partial objects inDrop::drop.Related issue
#1607