fix: Integer underflow risk in reader fetch partition_point #6787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
Xuanwo
reviewed
Nov 17, 2025
Comment on lines
+633
to
+634
| let merged_ranges = vec![100..200]; | ||
| let range = 50..60; |
Member
There was a problem hiding this comment.
merged_ranges are generated from ranges, so it shouldn't be possible to have 50..60 in 100..200.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6782
Rationale for this change
What changes are included in this PR?
This PR added validation to ensure each range is within its corresponding merged range and test test_fetch_partition_point_validation to verify the fix.
Are there any user-facing changes?
None