Conversation
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
dosubot
bot
added
size:L
tisonkun
commented
Nov 25, 2025
| /// Will panic if `max_size` is 0. | ||
| #[must_use] | ||
| pub fn connection_pool_max_size(mut self, max_size: u32) -> Self { | ||
| pub fn connection_pool_max_size(mut self, max_size: usize) -> Self { |
Member
Author
There was a problem hiding this comment.
This is a breaking change but I think it's OK. Our next version would be thus 0.56.0.
tisonkun
commented
Nov 25, 2025
| /// | ||
| /// default is 10 | ||
| pub connection_pool_max_size: Option<u32>, | ||
| pub connection_pool_max_size: Option<usize>, |
Contributor
|
Which caused a lot of format changes in doctest? |
Signed-off-by: tison <wander4096@gmail.com>
Member
Author
You can exclude 052cb4c from changeset. |
This reverts commit 052cb4c.
dosubot
bot
added
size:XL
Member
Author
|
Unstable format result. Revert the format commit for later dig in. |
tisonkun
commented
Nov 25, 2025
| options: options.clone(), | ||
| }, | ||
| ); | ||
|
|
Member
Author
There was a problem hiding this comment.
To add an idle_timeout feature, we may follow-up https://github.com/fast/fastpool/blob/355fb6769c6144220410114de307f5f793b61cb8/examples/postgres/src/main.rs#L40-L59
But let's only add it when it's really needed.
Xuanwo
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifiy code a lot.