feat: support if_not_exists in the Memory service #7036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
There was a problem hiding this comment.
Pull request overview
This PR adds support for the if_not_exists write capability to the Memory service, making it more compatible with other storage services. This is useful for testing scenarios where conditional writes are required.
- Implements
set_if_not_existsmethod in MemoryCore using atomic Entry API - Updates MemoryWriter to conditionally use the new method based on operation flags
- Declares the
write_with_if_not_existscapability in MemoryBackend
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core/core/src/services/memory/backend.rs | Declares write_with_if_not_exists: true capability |
| core/core/src/services/memory/core.rs | Adds thread-safe set_if_not_exists method with atomic check-and-insert logic |
| core/core/src/services/memory/writer.rs | Routes write operations to set_if_not_exists when the flag is set |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Xuanwo
changed the title
jcarey9149
pushed a commit
to jcarey9149/opendal
that referenced
this pull request
Dec 18, 2025
support if_not_exists in the Memory service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7035.
Rationale for this change
This makes the Memory service more of a drop-in replacement for other stores. I need this for testing in my project.
What changes are included in this PR?
The if_not_exists capability was added to the Memory service.
Are there any user-facing changes?
The Memory store now supports the
if_not_existscapability.AI Usage Statement
No AI was used in writing this code.