refactor(layers): Split logging layer into separate crate #7049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the logging layer implementation from core/core/src/layers/logging.rs to a separate crate at core/layers/logging. This follows the modular architecture pattern and improves build modularity. Changes: - Created opendal-layer-logging crate with proper manifest - Updated imports to use opendal_core prefix - Removed end-of-line comments from implementation - Added layers-logging feature flag to main Cargo.toml Co-Authored-By: Claude <noreply@anthropic.com>
dosubot
bot
added
size:M
Update dependencies to use the new layers-logging feature flag: - nodejs binding: add layers-logging feature - haskell binding: add layers-logging feature - testkit: add opendal-layer-logging dependency 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
let me ask AI for fixing it |
Add services-memory feature to dev-dependencies so doc tests can compile. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Apply taplo and rustfmt formatting. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The retry tests in opendal-core cannot use opendal-layer-logging because it would create a circular dependency (opendal-core -> opendal-layer-logging -> opendal-core). Remove the LoggingLayer usage from tests - it was added for debugging purposes only. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ependency" This reverts commit 194bfb9.
The retry layer tests are inline unit tests within opendal-core. These cannot use opendal-layer-logging because it would create a circular dependency (opendal-core tests -> opendal-layer-logging -> opendal-core). The testkit crate resolves this for external/behavior tests, but inline unit tests within core cannot use external layer crates. LoggingLayer was only used for debugging purposes in these tests. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
there is still a circular deps issue, I will take a look later |
Member
|
Hi @STRRL, Thank you for your work on this, but I think we'd better to extract the logging/retry/timeout layer crates in a single PR to avoid conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the logging layer implementation from core/core/src/layers/logging.rs to a separate crate at core/layers/logging. This follows the modular architecture pattern and improves build modularity.
Changes:
Which issue does this PR close?
Closes #6939
relates to #6829
Rationale for this change
N/A
What changes are included in this PR?
Are there any user-facing changes?
No I guess :P
AI Usage Statement
This PR was created with assistance from Claude Code (claude-opus-4-5-20251101).