feat: Binding Java's createInputStream and createOutputStream to support options #7097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eam operations and `Operator.read` method.
dosubot
bot
added
size:L
tisonkun
approved these changes
Dec 25, 2025
Member
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
Thanks for your contribution! LGTM.
To make ReadOptions more useful for OperatorInputStream, we may convey more option fields here.
Comment on lines
+77
to
+85
| try (final OperatorInputStream is = op.createInputStream( | ||
| path, ReadOptions.builder().offset(4L).length(5L).build())) { | ||
| final byte[] buffer = new byte[5]; | ||
| final int read = is.read(buffer, 0, 5); | ||
| assertThat(read).isEqualTo(5); | ||
| assertThat(new String(buffer)).isEqualTo("45678"); | ||
| } catch (Exception e) { | ||
| throw new RuntimeException(e); | ||
| } |
Member
There was a problem hiding this comment.
Interesting. What if we read once more?
That is, while I generally understand supporting ReadOptions to the input stream, I'm not quite sure what OpenDAL's reader should do if a range is specified - will it ends as finished? cc @Xuanwo
Member
There was a problem hiding this comment.
That is, while I generally understand supporting ReadOptions to the input stream, I'm not quite sure what OpenDAL's reader should do if a range is specified - will it ends as finished?
Yes, Reader is just read the input range and end with finished.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bindings(java): Support options for stream operations
Which issue does this PR close?
Closes #7077
Rationale for this change
Currently, the createInputStream and createOutputStream methods in the Java binding do not support passing options (such as
offset,length,content-type, etc.). This limitation prevents users from utilizing the full capabilities of OpenDAL when working with streams.This PR adds support for passing ReadOptions and WriteOptions to these methods, enabling more flexible and performant stream operations.
What changes are included in this PR?
Are there any user-facing changes?
Yes, new public API methods are added to Operator.java:
public OperatorInputStream createInputStream(String path, ReadOptions options)public OperatorOutputStream createOutputStream(String path, WriteOptions options)AI Usage Statement
This PR was implemented with the assistance of Gemini 3 pro