feat(services/s3): Add ACL on multipart upload#7255
Merged
Xuanwo merged 1 commit intoapache:mainfrom Mar 23, 2026
Merged
Conversation
dosubot
Bot
added
size:XS
The ACL were only put on whole upload not multipart
antoine-de
force-pushed
the
s3_multipart_acl
branch
from
b55fc12 to
96b97d3
Compare
Contributor
Author
|
CI complains about Ocaml formatting, but I don't think it's something of my part (and the branch seems up to date 🤔 ). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ACL were only put on whole upload not multipart
Which issue does this PR close?
Closes #7254
Rationale for this change
Default ACL introduced by #7186 are broken for big file (> 6M in my experience, but I don't really know the mechanism to choose whether to multipart or not).
What changes are included in this PR?
Like what is described in #7254, but adds ACL header to multipart upload (if defined as
default_acl.Note that since minio do not support file level ACL, I could not add integration tests for this.
Are there any user-facing changes?
Nop, only working ACL for all files.
AI Usage Statement
I did not use any AI to code this.