Skip to content

fix(observability): Fix http logic error metrics collection#7259

Merged
koushiro merged 2 commits intoapache:mainfrom
dentiny:hjiang/fix-resp-status-error
Mar 21, 2026
Merged

fix(observability): Fix http logic error metrics collection#7259
koushiro merged 2 commits intoapache:mainfrom
dentiny:hjiang/fix-resp-status-error

Conversation

@dentiny
Copy link
Copy Markdown
Contributor

@dentiny dentiny commented Mar 20, 2026

Which issue does this PR close?

Closes #7258

Rationale for this change

I noticed abnormally high opendal_http_executing metrics, and think it should account client OR server error instead of AND logic (how could an error be both client and server issue?)

Are there any user-facing changes?

No, no API change.

AI Usage Statement

No AI involvement.

@dentiny dentiny requested a review from Xuanwo as a code owner March 20, 2026 23:52
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. releases-note/fix The PR fixes a bug or has a title that begins with "fix" labels Mar 20, 2026
@dentiny dentiny changed the title Fix http logic error metrics collection fix(observability): Fix http logic error metrics collection Mar 21, 2026
Copy link
Copy Markdown
Member

@koushiro koushiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Mar 21, 2026
@dentiny
Copy link
Copy Markdown
Contributor Author

dentiny commented Mar 21, 2026

2026-03-21T07:45:42.2389697Z Failed to build exe:alex from alex-3.5.4.1.
2026-03-21T07:45:42.2390128Z Build log (
2026-03-21T07:45:42.2390894Z /home/runner/.cabal/logs/ghc-9.4.8/alex-3.5.4.1-e-alex-7211f11fe236d91e49090dcd008d5dfd28db596eb0474e9b7ebbe1bef4edb3de.log
2026-03-21T07:45:42.2391699Z ):
2026-03-21T07:45:42.2391899Z Error: [Cabal-7125]
2026-03-21T07:45:42.2392302Z Configuring executable 'alex' for alex-3.5.4.1...
2026-03-21T07:45:42.2392802Z Preprocessing executable 'alex' for alex-3.5.4.1...
2026-03-21T07:45:42.2393091Z Error: [Cabal-4123]
2026-03-21T07:45:42.2393334Z The program 'happy' is required but it could not be found

hmmm the CI failure doesn't seem to be related to my PR

@koushiro
Copy link
Copy Markdown
Member

2026-03-21T07:45:42.2389697Z Failed to build exe:alex from alex-3.5.4.1.
2026-03-21T07:45:42.2390128Z Build log (
2026-03-21T07:45:42.2390894Z /home/runner/.cabal/logs/ghc-9.4.8/alex-3.5.4.1-e-alex-7211f11fe236d91e49090dcd008d5dfd28db596eb0474e9b7ebbe1bef4edb3de.log
2026-03-21T07:45:42.2391699Z ):
2026-03-21T07:45:42.2391899Z Error: [Cabal-7125]
2026-03-21T07:45:42.2392302Z Configuring executable 'alex' for alex-3.5.4.1...
2026-03-21T07:45:42.2392802Z Preprocessing executable 'alex' for alex-3.5.4.1...
2026-03-21T07:45:42.2393091Z Error: [Cabal-4123]
2026-03-21T07:45:42.2393334Z The program 'happy' is required but it could not be found

hmmm the CI failure doesn't seem to be related to my PR

Yes, it should be a haskell toolchain and CI cache issue, let me fix it later

@koushiro koushiro merged commit 142b7c0 into apache:main Mar 21, 2026
71 of 73 checks passed
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Mar 21, 2026

Oh, yes! Thank you for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/fix The PR fixes a bug or has a title that begins with "fix" size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: a response error shouldn't be both server error and client error

3 participants