Skip to content

fix(s3): respect content encoding for multipart upload initialization#7274

Merged
Xuanwo merged 2 commits intoapache:mainfrom
dentiny:hjiang/set-content-encoding-multipart
Mar 24, 2026
Merged

fix(s3): respect content encoding for multipart upload initialization#7274
Xuanwo merged 2 commits intoapache:mainfrom
dentiny:hjiang/set-content-encoding-multipart

Conversation

@dentiny
Copy link
Copy Markdown
Contributor

@dentiny dentiny commented Mar 24, 2026

Which issue does this PR close?

Closes #7273

Rationale for this change

content-encoding is a valid request header for multipart upload creation, but it doesn't seem to be respected now.
The issue was found when I used opus-4.6 to do a sanity check to compare the request header difference between plain PUT and multipart upload, seems to be the only left one.

What changes are included in this PR?

Add the header to the request.

Are there any user-facing changes?

No

AI Usage Statement

Opus 4.6 helped me make the change.

@dentiny dentiny requested a review from Xuanwo as a code owner March 24, 2026 02:45
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. releases-note/fix The PR fixes a bug or has a title that begins with "fix" labels Mar 24, 2026
Copy link
Copy Markdown
Contributor

@yihong0618 yihong0618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Mar 24, 2026
@Xuanwo Xuanwo merged commit 90328cf into apache:main Mar 24, 2026
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/fix The PR fixes a bug or has a title that begins with "fix" size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: S3 multipart upload doesn't respect content encoding

4 participants