Skip to content

fix(layers/timeout): Fix timeout wrapper for delete operation#7279

Merged
Xuanwo merged 1 commit intoapache:mainfrom
dentiny:hjiang/fix-deletion-timeout
Mar 24, 2026
Merged

fix(layers/timeout): Fix timeout wrapper for delete operation#7279
Xuanwo merged 1 commit intoapache:mainfrom
dentiny:hjiang/fix-deletion-timeout

Conversation

@dentiny
Copy link
Copy Markdown
Contributor

@dentiny dentiny commented Mar 24, 2026

Which issue does this PR close?

Closes #7278

Rationale for this change

TimeoutWrapper applies io_timeout to every IO operations, but the deletion operation was missing the timeout wrapper.

What changes are included in this PR?

I mimic other operations in the same file, and update deletion operation accordingly.

Are there any user-facing changes?

No.

AI Usage Statement

Opus 4.6 helped me write the unit test.

@dentiny dentiny requested a review from Xuanwo as a code owner March 24, 2026 03:56
@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. releases-note/fix The PR fixes a bug or has a title that begins with "fix" labels Mar 24, 2026
Copy link
Copy Markdown
Member

@koushiro koushiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Mar 24, 2026
@koushiro koushiro changed the title fix(timeout): Fix timeout wrapper for deletion fix(layers/timeout): Fix timeout wrapper for delete operation Mar 24, 2026
@Xuanwo Xuanwo merged commit ffc9d97 into apache:main Mar 24, 2026
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/fix The PR fixes a bug or has a title that begins with "fix" size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: timeout wrapper doesn't respect timeout for deletion operation

3 participants