fix(delete): poll deleter close future on exit#7316
Merged
Xuanwo merged 3 commits intoapache:mainfrom Mar 26, 2026
Merged
Conversation
dosubot
Bot
added
size:M
Contributor
Author
|
Failed CI not related to my change :( info: syncing channel updates for 'stable-aarch64-apple-darwin'
error: failed to download file error=Reqwest(reqwest::Error { kind: Request, url: "https://static.rust-lang.org/dist/channel-rust-stable.toml.sha256", source: TimedOut })
error: could not download file from 'https://static.rust-lang.org/dist/channel-rust-stable.toml.sha256' to '/Users/runner/.rustup/tmp/m1dniga3gy13b2f5_file': error downloading file: error sending request for url (https://static.rust-lang.org/dist/channel-rust-stable.toml.sha256): operation timed out
Error: Process completed with exit code 1. |
dosubot
Bot
added
size:L
dentiny
force-pushed
the
hjiang/fix-delete-exit
branch
from
46f4cda to
43f71f2
Compare
dosubot
Bot
added
size:M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7315
Rationale for this change
On delete sink close, current implementation directly creates and drops close future, inside of which batch delete all left unsent requests.
What changes are included in this PR?
This PR checks close future before exit, to make sure all left unsent requests are taken care of.
Are there any user-facing changes?
No.
AI Usage Statement
Opus 4.6 crafted tests to trigger the issue.