Skip to content

fix(correctness check): add missing conditional write capability check#7320

Merged
Xuanwo merged 1 commit intoapache:mainfrom
dentiny:hjiang/add-conditional-write-capability-check
Mar 26, 2026
Merged

fix(correctness check): add missing conditional write capability check#7320
Xuanwo merged 1 commit intoapache:mainfrom
dentiny:hjiang/add-conditional-write-capability-check

Conversation

@dentiny
Copy link
Copy Markdown
Contributor

@dentiny dentiny commented Mar 26, 2026

Which issue does this PR close?

Closes #7319

Rationale for this change

Conditional write is an important feature and we should validate user request against storage backend capability.

What changes are included in this PR?

Check the capability for conditional write if the user request includes.

Are there any user-facing changes?

No

AI Usage Statement

Opus 4.6 found the missing check.

@dentiny dentiny requested a review from Xuanwo as a code owner March 26, 2026 07:42
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. releases-note/fix The PR fixes a bug or has a title that begins with "fix" labels Mar 26, 2026
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Mar 26, 2026
@Xuanwo Xuanwo merged commit 8232a8d into apache:main Mar 26, 2026
372 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/fix The PR fixes a bug or has a title that begins with "fix" size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: correctness check miss to check conditional write

2 participants