feat(bindings/dotnet):Bindings dotnet publish to nuget#7323
feat(bindings/dotnet):Bindings dotnet publish to nuget#7323tisonkun merged 3 commits intoapache:mainfrom
Conversation
dosubot
bot
added
size:L
Fatorin
changed the title
Fatorin
changed the title
| if classifier == "osx-x86_64": | ||
| return "x86_64-apple-darwin" |
There was a problem hiding this comment.
@Fatorin Is this something .NET cannot support, or we do not support it due to its outdated?
There was a problem hiding this comment.
This is not a limitation of .NET.
As modern Macs have largely transitioned to Apple Silicon (M-series), So I decided not to include osx-x64.
However, it can still be added if needed.
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
LGTM.
You may investigate whether we have some methods to do a pre-release so that we can early evaluate the release workflow.
| on: | ||
| push: | ||
| tags: | ||
| - 'dotnet-v[0-9]+.[0-9]+.[0-9]+*' |
There was a problem hiding this comment.
Maybe change to v[0-9]+.[0-9]+.[0-9]+ or v[0-9]+.[0-9]+.[0-9]+-rc.[0-9]+ depending on how the .NET release workflow would actually trigger.
I think we don't push tags like dotnet-v[0-9]+.[0-9]+.[0-9]+* so far.
But I'm OK to leave it as is for now since this workflow is untested anyway.
2 participants
Which issue does this PR close?
Closes #7299
Rationale for this change
Introduce official .NET bindings publishing to NuGet for the project.
What changes are included in this PR?
Adjust the .csproj configuration to support proper packaging of the library.
Implement release scripts in the CI/CD pipeline using GitHub Actions.
Fix an issue in the .NET bindings where the async state was not correctly handled on failure.
Are there any user-facing changes?
Removed the osx-x64 build from build.py.
Most developers are using osx-aarch64, so maintaining the osx-x64 build is no longer necessary.
Publishing requires manual activation on NuGet ("Activate for 7 days") due to Trusted Publishing.
AI Usage Statement
This PR was developed with Codex (GPT-5.3) assistance.