fix(core): fix deadlock for concurrent read and concurrent limit layer#7346
Open
dentiny wants to merge 1 commit intoapache:mainfrom
Open
fix(core): fix deadlock for concurrent read and concurrent limit layer#7346dentiny wants to merge 1 commit intoapache:mainfrom
dentiny wants to merge 1 commit intoapache:mainfrom
Conversation
f38c359 to
f670349
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7338
Rationale for this change
I met process stuck and deadlock in production environment, which turns out to be deadlock between concurrent limit & concurrent read.
This PR tries to fix the potential deadlock.
Before this PR
After this change
What changes are included in this PR?
During the investigation I found only current read suffers the potential deadlock but not concurrent write.
This PR mimics what we do in concurrent write, which issues requests in the background so we don't block on the foreground when ConcurrentTasks issue new read requests.
Are there any user-facing changes?
No.
AI Usage Statement
Opus 4.6 made the code change.