Skip to content

fix(s3): add missing content write content disposition capability#7349

Merged
Xuanwo merged 1 commit intoapache:mainfrom
dentiny:hjiang/fix-s3-content-disposition
Apr 1, 2026
Merged

fix(s3): add missing content write content disposition capability#7349
Xuanwo merged 1 commit intoapache:mainfrom
dentiny:hjiang/fix-s3-content-disposition

Conversation

@dentiny
Copy link
Copy Markdown
Contributor

@dentiny dentiny commented Apr 1, 2026

Rationale for this change

S3 supports content disposition as part of the PUT request: https://docs.aws.amazon.com/AmazonS3/latest/API/API_PutObject.html#API_PutObject_RequestSyntax

S3 requests already fill in corresponding header here:

if let Some(pos) = args.content_disposition() {
req = req.header(CONTENT_DISPOSITION, pos)
}

Before this fix, I think capability check layer validation will fail

if !capability.write_with_content_disposition && args.content_disposition().is_some() {

What changes are included in this PR?

Declare S3 backend supports content disposition for write operations.

Are there any user-facing changes?

No

AI Usage Statement

Opus 4.6 helped me found the missing capability declaration.

@dentiny dentiny requested a review from Xuanwo as a code owner April 1, 2026 08:47
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. releases-note/fix The PR fixes a bug or has a title that begins with "fix" labels Apr 1, 2026
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank yoU!

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 1, 2026
@Xuanwo Xuanwo merged commit 3665c8b into apache:main Apr 1, 2026
383 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/fix The PR fixes a bug or has a title that begins with "fix" size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants